Agreed. The only benefit of showing a "yakuless" hand is the fu counting I guess? But even then it should be an option you can turn on if you're just doing Fu practice or something like that. It shouldn't be a core feature that's always on.Shirluban wrote: ↑Mon Jul 29, 2019 3:12 pmhttps://www.reddit.com/r/Mahjong/commen ... alculator/1) AFAIK, a valid hand is 4 groups and a pair, or 7 different pairs, or kokushi musō.The payments for any valid hand are calculated, even if the hand is yaku nashi. This is a "feature" that ended up being a "design choice". How the calculator works is that it first tries to assemble a valid hand. A valid hand is 4 sets and a pair, or 7 pairs, or a kokushi musou hand. Then, if a valid hand is found it loops through a list of yaku to see if the hand matches any. At the end the results are displayed, even if there are no valid yaku. My thinking process was that I had no real reason not to cancel the display. The calculator must do all the looping to find a valid hand in the first place, which is where most of the processing time is. So I thought, why not? It might be a bit confusing to newer players, but I think it is an interesting enough "feature" to warrant it.
Not just seven pairs.
2) "Then, if a valid hand is found it loops through a list of yaku to see if the hand matches any. At the end the results are displayed, even if there are no valid yaku."
At this point, the result must shows "invalid hand: no yaku".
There are no reasons to "cancel the display", indeed, but it still has to display the correct score. Where lies the computation time's bottleneck is irrelevant, only user experience matters; and something both confusing to newbies and useless to seasoned players is terrible UX.
Again agreed. Yes the scoring side of things can be a pain, but that in itself should be a reason for rigorous testing from external users.Shirluban wrote: ↑Mon Jul 29, 2019 3:12 pmTrue.
But then it's shouldn't be distributed without intensive testing. Or it should clearly be labelled as a beta version, requesting help to find out the bugs.
The dev is being irresponsible by recommending it "if you are just starting out" while admitting "it might be a bit confusing to newer players".